Skip to content

Samples for 2025#51

Merged
nshadskiy merged 11 commits into
mainfrom
fixes_samples
May 12, 2026
Merged

Samples for 2025#51
nshadskiy merged 11 commits into
mainfrom
fixes_samples

Conversation

@sofiagiappichini
Copy link
Copy Markdown
Contributor

  • New samples for 2025, data is appropriate, while MC is copied from 2024 with a different nick to differentiate them.
  • Run maintenance on the rest of the samples, mostly to update the filelists and gene weights.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds/refreshes NanoAOD v12 sample JSONs (notably 2022postEE data eras E/G) and performs maintenance updates to existing sample metadata/filelists.

Changes:

  • Updated diboson MC filelists to use a different XRootD endpoint.
  • Added new 2022postEE data sample JSONs for several datasets (Muon/EGamma/JetMET/Tau) in eras E and G.
  • Reclassified a 2018 ttH sample into the rem_htautau sample_type and added a corresponding JSON under rem_htautau/.

Reviewed changes

Copilot reviewed 29 out of 4914 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
nanoAOD_v12/2022postEE/diboson/WZto2L2Q_TuneCP5_13p6TeV_powheg-pythia8_Run3Summer22EENanoAODv12-130X.json Switches MC filelist redirector endpoint.
nanoAOD_v12/2022postEE/diboson/WWto2L2Nu_TuneCP5_13p6TeV_powheg-pythia8_Run3Summer22EENanoAODv12-130X.json Switches MC filelist redirector endpoint.
nanoAOD_v12/2022postEE/data_G/Tau_Run2022G-22Sep2023-v1.json Adds new 2022postEE data(G) Tau sample definition.
nanoAOD_v12/2022postEE/data_G/Muon_Run2022G-22Sep2023-v1.json Adds new 2022postEE data(G) Muon sample definition.
nanoAOD_v12/2022postEE/data_G/Muon_Run2022G-19Dec2023-v2.json Adds new 2022postEE data(G) Muon sample definition (19Dec reprocessing).
nanoAOD_v12/2022postEE/data_G/JetMET_Run2022G-22Sep2023-v2.json Adds new 2022postEE data(G) JetMET sample definition.
nanoAOD_v12/2022postEE/data_G/EGamma_Run2022G-22Sep2023-v2.json Adds new 2022postEE data(G) EGamma sample definition.
nanoAOD_v12/2022postEE/data_G/EGamma_Run2022G-16Dec2023-v1.json Adds new 2022postEE data(G) EGamma sample definition (16Dec reprocessing).
nanoAOD_v12/2022postEE/data_E/Tau_Run2022E-22Sep2023-v1.json Adds new 2022postEE data(E) Tau sample definition.
nanoAOD_v12/2022postEE/data_E/Muon_Run2022E-22Sep2023-v1.json Adds new 2022postEE data(E) Muon sample definition.
nanoAOD_v12/2022postEE/data_E/Muon_Run2022E-16Dec2023-v1.json Adds new 2022postEE data(E) Muon sample definition (16Dec reprocessing).
nanoAOD_v12/2022postEE/data_E/JetMET_Run2022E-22Sep2023-v1.json Adds new 2022postEE data(E) JetMET sample definition.
nanoAOD_v12/2022postEE/data_E/EGamma_Run2022E-16Dec2023-v1.json Adds new 2022postEE data(E) EGamma sample definition (16Dec reprocessing).
nanoAOD_v12/2018/ttH/ttHToNonbb_M125_TuneCP5_13TeV-powheg-pythia8_sdaigler-mc_2018UL_Higgs_ttHToNonbb_1736873492-00000000000000000000000000000000.json Changes sample_type classification of an existing 2018 ttH sample.
nanoAOD_v12/2018/rem_htautau/ttHToNonbb_M125_TuneCP5_13TeV-powheg-pythia8_sdaigler-mc_2018UL_Higgs_ttHToNonbb_1736873492-00000000000000000000000000000000.json Adds a new JSON copy of the same sample under rem_htautau/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread nanoAOD_v12/2022postEE/data_G/Muon_Run2022G-19Dec2023-v2.json Outdated
Comment thread nanoAOD_v15/datasets.json.working Outdated
@nshadskiy
Copy link
Copy Markdown
Collaborator

For the nanoAODv9 changes, as I understand e.g. for 2018 it was only "era": "2018", to "era": 2018,. However, I would like to revert this to have a consistent definition of the era parameter type as a string since we can not do integer for cases like "2016preVFP" or "2023postBPix".

@nshadskiy
Copy link
Copy Markdown
Collaborator

This PR shows a general issue with the sample_manager that still need to be fixed after this PR is merged. See #54

@nshadskiy nshadskiy merged commit 6f18469 into main May 12, 2026
@nshadskiy nshadskiy deleted the fixes_samples branch May 12, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants